Some beforeRequest edited options are discarded

[Giotino]

Currently he edits of options.agent and options.url made in beforeRequest are discarded.

This PR simply read agent and url after beforeRequest hooks.

Checklist

• I have read the documentation.
• I have included a pull request description of my changes.
• I have included some tests.

Fixes #1292

[Giotino]

Also i wanted to talk about the "unix socket url parsing" before the request.

Documentation for beforeRequest:

Got will make no further changes to the request before it is sent

But this code is modifying some options, after beforeRequest but before the request.
https://github.com/sindresorhus/got/blob/master/source/core/index.ts#L1360,L1372

I think this code should be moved before beforeRequest.

[szmarczak]

I think this code should be moved before beforeRequest.

No, it should stay where it is. It just translates unix hostname to Node.js native options.

[szmarczak]

https://travis-ci.com/github/sindresorhus/got/jobs/340837947#L756

$ node --version
v14.3.0

...

  ✖ Timed out while running tests
  1 tests were pending in test/http.ts
  ◌ http.ts › throws an error if the server aborted the request

Can you figure out why it fails please?

[Giotino]

https://travis-ci.com/github/sindresorhus/got/jobs/340837947#L756

$ node --version
v14.3.0

...

  ✖ Timed out while running tests
  1 tests were pending in test/http.ts
  ◌ http.ts › throws an error if the server aborted the request

Can you figure out why it fails please?

Even the master branch is failing the same test, for the same reason.
I'm trying to figure out why.

[Giotino]

By doing some test it seems to happen only with Node.JS >= 14.3.0
Node.JS 14.2.0: 22 tests passed (only http test were run)

[Giotino]

These Node.JS commits (merged into 14.3.0) could be relevant to this issue:
nodejs/node@b634d4b000
nodejs/node@cc5c8e039d