New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dnsLookupIpVersion
option
#1264
Conversation
Added explicit type (not inherited from Node.JS types)
family
optionfamily
option
Added a note about the `family` option in the README Some cleanups
I've added some IPv6 (and DNS) related tests. It seems like Travis CI is missing IPv6 support, event on loopback. |
Since |
Can you also add a |
According to the Node.JS documentation |
There are benefits to
|
I'm working on the "deprecation utilty" in this PR #1255 |
Co-authored-by: Szymon Marczak <36894700+szmarczak@users.noreply.github.com>
This looks good except for the missing deprecation warning. |
Co-authored-by: Sindre Sorhus <sindresorhus@gmail.com>
Co-authored-by: Sindre Sorhus <sindresorhus@gmail.com>
https://travis-ci.com/github/sindresorhus/got/jobs/341303159#L480
|
the stack trace is mangled so you have to run the tests without |
There was a race condition on the two |
family
optiondnsLookupIpVersion
option
Very nice work, @Giotino 👌 |
Co-authored-by: Szymon Marczak <36894700+szmarczak@users.noreply.github.com> Co-authored-by: Sindre Sorhus <sindresorhus@gmail.com>
@sindresorhus Maybe let's use numbers but |
Yeah, that would be nicer. |
Checklist
I've added the documentation relative to the
family
property. I've also added a stricter type definition.I think the name "family" it's a little generic, it might be renamed to "IPfamily" or something like that.
Fixes #1263