Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not destroy completed requests #1248

Merged
merged 5 commits into from
May 12, 2020
Merged

Do not destroy completed requests #1248

merged 5 commits into from
May 12, 2020

Conversation

szmarczak
Copy link
Collaborator

Fixes #1245

Checklist

  • I have read the documentation.
  • I have included a pull request description of my changes.
  • I have included some tests.
  • If it's a new feature, I have included documentation updates.

@sindresorhus
Copy link
Owner

Is the plan to upstream these changes? If so, maybe add a TODO comment.

@szmarczak szmarczak merged commit b9b6b1e into sindresorhus:master May 12, 2020
@szmarczak szmarczak deleted the dont-destroy branch May 12, 2020 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sindresorhus sindresorhus sindresorhus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Socket hang up with parallel requests and maxSockets agent options with node >= 14.1.0
2 participants
@szmarczak @sindresorhus