Issue with Http2 Integration Understanding

[prabhatmishra33]

What would you like to discuss?

I was to discuss about the http2 implementation with GOT. Below changes i have done as to implement http2 for GOT.

• Upgraded Node to v15.10.0

• added http2: true into my options. you can see below
  let options = { retry: httpClient.getRetryConfig(url), timeout: 5000, responseType: 'json', agent: httpClient.getHttpAgent(), maxContentLength: Infinity, http2: true };

• Added http2 in the agent
  `
  const HttpAgent = require('agentkeepalive');
  const { HttpsAgent } = HttpAgent;
  const Http2Wrapper = require('http2-wrapper');

    http: new HttpAgent(),
    https: new HttpsAgent(),
    http2: new Http2Wrapper.Agent()
  

`
Please let me know if some more changes needed to be integrated
...

Checklist

node v15.10.0
"got": "^11.8.2"
"http2-wrapper": "^1.0.3"
"agentkeepalive": "^4.1.4"

• I have read the documentation.
  https://www.npmjs.com/package/got#http2

[sindresorhus]

What issue are you seeing?

[prabhatmishra33]

@sindresorhus @szmarczak could you please tell me how can i achieve this using GOT ?
As in response headers i still receive 1.1
{ ':status': 200, date: 'Sat, 01 May 2021 17:43:00 GMT', 'content-type': 'application/json', 'content-length': '372', 'access-control-allow-origin': '*', 'access-control-allow-credentials': 'true', 'x-backend-header-rtt': '0.003452', 'strict-transport-security': 'max-age=31536000', server: 'nghttpx', via: '1.1 nghttpx', 'alt-svc': 'h3-29=":443"; ma=3600', 'x-frame-options': 'SAMEORIGIN', 'x-xss-protection': '1; mode=block', 'x-content-type-options': 'nosniff', [Symbol(nodejs.http2.sensitiveHeaders)]: [] }

[szmarczak]

I don't know what's your problem. Everything works correctly here.

[prabhatmishra33]

Hi @szmarczak In you below example as per document
const got = require('got');

(async () => {
const {headers} = await got('https://nghttp2.org/httpbin/anything', {http2: true});
console.log(headers.via);
//=> '2 nghttpx'
})();

if via: '2 nghttpx then we consider this as an api using HTTP2 but in my case it's coming as via: '1.1 nghttpx'

[szmarczak]

Don't worry, the request is still via HTTP/2. Have you read #1708 (reply in thread)

[prabhatmishra33]

ok Thanks for confirming.