/
abort.ts
329 lines (252 loc) 路 9.01 KB
/
abort.ts
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
import process from 'process';
import {EventEmitter} from 'events';
import stream, {Readable as ReadableStream} from 'stream';
import test from 'ava';
import delay from 'delay';
import {pEvent} from 'p-event';
import type {Handler} from 'express';
import {createSandbox} from 'sinon';
import got from '../source/index.js';
import slowDataStream from './helpers/slow-data-stream.js';
import type {GlobalClock} from './helpers/types.js';
import type {ExtendedHttpTestServer} from './helpers/create-http-test-server.js';
import withServer, {withServerAndFakeTimers} from './helpers/with-server.js';
// eslint-disable-next-line no-negated-condition
if (globalThis.AbortController !== undefined) {
const prepareServer = (server: ExtendedHttpTestServer, clock: GlobalClock): {emitter: EventEmitter; promise: Promise<unknown>} => {
const emitter = new EventEmitter();
const promise = new Promise<void>((resolve, reject) => {
server.all('/abort', async (request, response) => {
emitter.emit('connection');
request.once('aborted', resolve);
response.once('finish', reject.bind(null, new Error('Request finished instead of aborting.')));
try {
await pEvent(request, 'end');
} catch {
// Node.js 15.0.0 throws AND emits `aborted`
}
response.end();
});
server.get('/redirect', (_request, response) => {
response.writeHead(302, {
location: `${server.url}/abort`,
});
response.end();
emitter.emit('sentRedirect');
clock.tick(3000);
resolve();
});
});
return {emitter, promise};
};
const downloadHandler = (clock?: GlobalClock): Handler => (_request, response) => {
response.writeHead(200, {
'transfer-encoding': 'chunked',
});
response.flushHeaders();
stream.pipeline(
slowDataStream(clock),
response,
() => {
response.end();
},
);
};
const sandbox = createSandbox();
const createAbortController = (): {controller: AbortController; signalHandlersRemoved: () => boolean} => {
const controller = new AbortController();
sandbox.spy(controller.signal);
// @ts-expect-error AbortSignal type definition issue: https://github.com/DefinitelyTyped/DefinitelyTyped/discussions/57805
const signalHandlersRemoved = () => controller.signal.addEventListener.callCount === controller.signal.removeEventListener.callCount;
return {
controller, signalHandlersRemoved,
};
};
test.afterEach(() => {
sandbox.restore();
});
test.serial('does not retry after abort', withServerAndFakeTimers, async (t, server, got, clock) => {
const {emitter, promise} = prepareServer(server, clock);
const {controller, signalHandlersRemoved} = createAbortController();
const gotPromise = got('redirect', {
signal: controller.signal,
retry: {
calculateDelay() {
t.fail('Makes a new try after abort');
return 0;
},
},
});
emitter.once('sentRedirect', () => {
controller.abort();
});
await t.throwsAsync(gotPromise, {
code: 'ERR_ABORTED',
message: 'This operation was aborted.',
});
await t.notThrowsAsync(promise, 'Request finished instead of aborting.');
t.true(signalHandlersRemoved(), 'Abort signal event handlers not removed');
});
test.serial('abort request timeouts', withServer, async (t, server, got) => {
server.get('/', () => {});
const {controller, signalHandlersRemoved} = createAbortController();
const gotPromise = got({
signal: controller.signal,
timeout: {
request: 10,
},
retry: {
calculateDelay({computedValue}) {
process.nextTick(() => {
controller.abort();
});
if (computedValue) {
return 20;
}
return 0;
},
limit: 1,
},
});
await t.throwsAsync(gotPromise, {
code: 'ERR_ABORTED',
message: 'This operation was aborted.',
});
t.true(signalHandlersRemoved(), 'Abort signal event handlers not removed');
// Wait for unhandled errors
await delay(40);
});
test.serial('aborts in-progress request', withServerAndFakeTimers, async (t, server, got, clock) => {
const {emitter, promise} = prepareServer(server, clock);
const {controller, signalHandlersRemoved} = createAbortController();
const body = new ReadableStream({
read() {},
});
body.push('1');
const gotPromise = got.post('abort', {body, signal: controller.signal});
// Wait for the connection to be established before canceling
emitter.once('connection', () => {
controller.abort();
body.push(null);
});
await t.throwsAsync(gotPromise, {
code: 'ERR_ABORTED',
message: 'This operation was aborted.',
});
await t.notThrowsAsync(promise, 'Request finished instead of aborting.');
t.true(signalHandlersRemoved(), 'Abort signal event handlers not removed');
});
test.serial('aborts in-progress request with timeout', withServerAndFakeTimers, async (t, server, got, clock) => {
const {emitter, promise} = prepareServer(server, clock);
const {controller, signalHandlersRemoved} = createAbortController();
const body = new ReadableStream({
read() {},
});
body.push('1');
const gotPromise = got.post('abort', {body, timeout: {request: 10_000}, signal: controller.signal});
// Wait for the connection to be established before canceling
emitter.once('connection', () => {
controller.abort();
body.push(null);
});
await t.throwsAsync(gotPromise, {
code: 'ERR_ABORTED',
message: 'This operation was aborted.',
});
await t.notThrowsAsync(promise, 'Request finished instead of aborting.');
t.true(signalHandlersRemoved(), 'Abort signal event handlers not removed');
});
test.serial('abort immediately', withServerAndFakeTimers, async (t, server, got, clock) => {
const {controller, signalHandlersRemoved} = createAbortController();
const promise = new Promise<void>((resolve, reject) => {
// We won't get an abort or even a connection
// We assume no request within 1000ms equals a (client side) aborted request
server.get('/abort', (_request, response) => {
response.once('finish', reject.bind(global, new Error('Request finished instead of aborting.')));
response.end();
});
clock.tick(1000);
resolve();
});
const gotPromise = got('abort', {signal: controller.signal});
controller.abort();
await t.throwsAsync(gotPromise, {
code: 'ERR_ABORTED',
message: 'This operation was aborted.',
});
await t.notThrowsAsync(promise, 'Request finished instead of aborting.');
t.true(signalHandlersRemoved(), 'Abort signal event handlers not removed');
});
test('recover from abort using abortable promise attribute', async t => {
// Abort before connection started
const {controller, signalHandlersRemoved} = createAbortController();
const p = got('http://example.com', {signal: controller.signal});
const recover = p.catch((error: Error) => {
if (controller.signal.aborted) {
return;
}
throw error;
});
controller.abort();
await t.notThrowsAsync(recover);
t.true(signalHandlersRemoved(), 'Abort signal event handlers not removed');
});
test('recover from abort using error instance', async t => {
const {controller, signalHandlersRemoved} = createAbortController();
const p = got('http://example.com', {signal: controller.signal});
const recover = p.catch((error: Error) => {
if (error.message === 'This operation was aborted.') {
return;
}
throw error;
});
controller.abort();
await t.notThrowsAsync(recover);
t.true(signalHandlersRemoved(), 'Abort signal event handlers not removed');
});
// TODO: Use `fakeTimers` here
test.serial('throws on incomplete (aborted) response', withServer, async (t, server, got) => {
server.get('/', downloadHandler());
const {controller, signalHandlersRemoved} = createAbortController();
const promise = got('', {signal: controller.signal});
setTimeout(() => {
controller.abort();
}, 400);
await t.throwsAsync(promise, {
code: 'ERR_ABORTED',
message: 'This operation was aborted.',
});
t.true(signalHandlersRemoved(), 'Abort signal event handlers not removed');
});
test('throws when aborting cached request', withServer, async (t, server, got) => {
server.get('/', (_request, response) => {
response.setHeader('Cache-Control', 'public, max-age=60');
response.end(Date.now().toString());
});
const cache = new Map();
await got({cache});
const {controller, signalHandlersRemoved} = createAbortController();
const promise = got({cache, signal: controller.signal});
controller.abort();
await t.throwsAsync(promise, {
code: 'ERR_ABORTED',
message: 'This operation was aborted.',
});
t.true(signalHandlersRemoved(), 'Abort signal event handlers not removed');
});
test('support setting the signal as a default option', async t => {
const {controller, signalHandlersRemoved} = createAbortController();
const got2 = got.extend({signal: controller.signal});
const p = got2('http://example.com', {signal: controller.signal});
controller.abort();
await t.throwsAsync(p, {
code: 'ERR_ABORTED',
message: 'This operation was aborted.',
});
t.true(signalHandlersRemoved(), 'Abort signal event handlers not removed');
});
} else {
test('x', t => {
t.pass();
});
}