{extension: false} and expandDirectories.extensions don't work together

[garyking]

If using noext: true (or extension: false, which is the same thing), and expandDirectories.extensions, then no results will be returned.

Example:

globby.sync(dirPath, {
  expandDirectories: {
    // Must have more than one extension here.
    extensions: ['md', 'txt'],
  },
  extension: false,
})

---

IssueHunt Summary

janat08 has been rewarded.

Backers (Total: $40.00)

• issuehunt ($40.00)

Submitted pull Requests

• #124 97

---

Tips

• Checkout the Issuehunt explorer to discover more funded issues.
• Need some help from other developers? Add your repositories on IssueHunt to raise funds.

---

IssueHunt has been backed by the following sponsors. Become a sponsor

[sindresorhus]

Would you be able to submit a pull request with one or more failing tests? That would help getting this fixed faster.

[garyking]

@sindresorhus Done

[IssueHuntBot]

@IssueHunt has funded $40.00 to this issue. See it on IssueHunt

[medusalix]

dir-glob is appending all extensions to the glob pattern: tmp\\**\\*.{md,tmp}. The option noext turns extglob support off, so fast-glob is unable to resolve the pattern.

@sindresorhus Should we just display a warning/error when both options are used simultaneously? That would of course need some kind of documentation.

[sindresorhus]

@medusalix According to the fast-glob docs, the noext options disables patterns like +(a|b)). dir-glob doesn't use that pattern syntax, it uses brace expansion, which is a different option nobrace.

[medusalix]

@sindresorhus fast-glob uses micromatch, which turns tmp\\**\\*.{md,tmp} into tmp/**/*.(md|tmp) using brace expansion. When noext is specified, literal parentheses get matched:

it('should match literal parens when noext is true (issue #116)', function() {
    assert(mm.isMatch('a/(dir)', 'a/(dir)', {noext: true}));
});

[medusalix]

@sindresorhus We could just throw an error if noext: true and expandDirectories.extensions are used together.

[sindresorhus]

That sounds like a leaked implementation detail and should be reported to fast-glob. Can you open an issue on fast-glob about this?

But yes, we should still throw an error for now until it's fixed in fast-glob.

[janat08]

the issue I opened isn't actionable apparently.

[janat08]

mrmlnc/fast-glob#181

[issuehunt-oss]

@sindresorhus has rewarded $36.00 to @janat08. See it on IssueHunt

• 💰 Total deposit: $40.00
• 🎉 Repository reward(0%): $0.00
• 🔧 Service fee(10%): $4.00