Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve task expansion #219

Merged
merged 1 commit into from Jan 19, 2022
Merged

Improve task expansion #219

merged 1 commit into from Jan 19, 2022

Conversation

fisker
Copy link
Collaborator

@fisker fisker commented Jan 19, 2022

fast-glob accepts array as patterns, so we don't need flat tasks.

I'm not sure if this improves performance, but I don't think it will be slower.

In generateGlobTasks we can also avoid use multiple task, but I don't if worth to improve that part.

The benchmark test is broken, maybe I can tell if we fix that?

@sindresorhus
Copy link
Owner

And if it's slower, it should ideally be fixed in fast-glob, so it benefits everyone.

@sindresorhus sindresorhus merged commit 09171d9 into sindresorhus:main Jan 19, 2022
@sindresorhus
Copy link
Owner

The benchmark test is broken, maybe I can tell if we fix that?

Feel free to fix it, but simple benchmarks don't usually tell the full story. It only focuses on one specific performance case.

@fisker fisker deleted the no-flat branch January 19, 2022 07:12
@fisker fisker mentioned this pull request Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants