Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify task expansion #215

Merged
merged 3 commits into from Jan 19, 2022
Merged

Simplify task expansion #215

merged 3 commits into from Jan 19, 2022
+70 −66

Conversation

fisker
Copy link
Collaborator

@fisker fisker commented Jan 18, 2022 •
edited

  • Merge expand pattern and expand ignore into one step
  • Skip expand when options.expandDirectories is false, we calling Array#map() unnecessarily before

@fisker fisker mentioned this pull request Jan 18, 2022
Merged
@fisker fisker marked this pull request as ready for review January 19, 2022 02:43
@fisker
Copy link
Collaborator Author

fisker commented Jan 19, 2022

There's another thing to do after this. We are normalizing expandDirectories repeatedly.

@fisker fisker changed the title Simplify expandDirectories Simplify task expansion Jan 19, 2022
@sindresorhus sindresorhus merged commit 128772a into sindresorhus:main Jan 19, 2022
@fisker fisker deleted the expand-tasks branch January 19, 2022 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fisker @sindresorhus