Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support objectMode option in the TypeScript types #178

Merged
merged 4 commits into from Jun 16, 2021
Merged

Support objectMode option in the TypeScript types #178

merged 4 commits into from Jun 16, 2021

Conversation

Purpzie
Copy link
Contributor

@Purpzie Purpzie commented Jun 15, 2021

Fixes #177
Closes #174

@sindresorhus sindresorhus changed the title Add overloads for objectMode Support objectMode option in the TypeScript types Jun 15, 2021
@sindresorhus
Copy link
Owner

Type tests are failing

@Purpzie
Copy link
Contributor Author

Purpzie commented Jun 15, 2021

Oh woops. Forgot that more specific overloads should be specified before more generic ones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Types: string[] is still assumed to be returned even if the objectMode option is true
2 participants