Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of glob dependency #135

Merged
merged 5 commits into from Jan 6, 2020
Merged

Get rid of glob dependency #135

merged 5 commits into from Jan 6, 2020

Conversation

mrmlnc
Copy link
Contributor

@mrmlnc mrmlnc commented Oct 7, 2019 •
edited by sindresorhus

What is the purpose of this pull request?

Fixes #109

What changes did you make? (Give an overview)

  • Replace glob.hasMagic by fg.isDynamicPattern;
  • Update documentation in the README.md and .d.ts files;
  • Drop glob and @types/glob dependencies;

@Schweinepriester
Copy link

Friendly ping @sindresorhus 0:-)

@sindresorhus sindresorhus changed the title ISSUE-109: Get rid of glob dependency Get rid of glob dependency Nov 6, 2019
@sindresorhus sindresorhus merged commit d4681a4 into sindresorhus:master Jan 6, 2020
@sindresorhus
Copy link
Owner

sindresorhus commented Jan 6, 2020 •
edited

Thanks, @mrmlnc 🙌

@admataz admataz mentioned this pull request Jul 6, 2020
Closed
@loynoir loynoir mentioned this pull request Mar 20, 2022
Closed
@Omrisnyk Omrisnyk mentioned this pull request Nov 30, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Get rid of glob dependency
3 participants
@mrmlnc @Schweinepriester @sindresorhus