Don't throw when specifying a non-existing cwd directory
#125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
sindresorhus
requested changes
Jun 23, 2019
|
The PR needs a better title. |
popomore
changed the title
|
@sindresorhus PR is updated. |
sindresorhus
changed the title
cwd directory
kevva
reviewed
Jul 5, 2019
|
|
||
| let stat; | ||
| try { | ||
| stat = fs.statSync(options.cwd); |
There was a problem hiding this comment.
Do we want to do this synchronously?
There was a problem hiding this comment.
We probably want a separate async version of this check. I might have been too lazy to do that initially or just forgot. PR welcome :)
There was a problem hiding this comment.
Yeah, I think we'll need it since we use globby in a lot of modules and this might result in a small decrease in performance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.