Add globby.stream
#113
Merged
Add globby.stream
#113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexzherdev
reviewed
Apr 6, 2019
|
You also need to update https://github.com/sindresorhus/globby/blob/master/index.d.ts |
sindresorhus
requested changes
Jun 14, 2019
|
Can you fix the merge conflicts? |
Co-Authored-By: Sindre Sorhus <sindresorhus@gmail.com>
|
I have addressed all the review comments 👌 |
|
Thanks 🙌 You need to submit the PR URL here to claim the bounty: https://issuehunt.io/r/sindresorhus/globby/issues/83 |
This was referenced Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #83
This adds support for async iteration by adding
globby.streamwhich returns aReadableStream.Node 10 introduced experimental async iterator support to
ReadableStreamso if supported by one's node version, one can useglobby.streamin afor-await-ofloop as witnessed by this test https://github.com/futpib/globby/blob/958e81505b1baa7d73e29dbe3468123032cce9cf/test.js#L85-L92