Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make decomposing characters optional. #35

Open
issuefiler opened this issue May 25, 2022 · 0 comments
Open

Make decomposing characters optional. #35

issuefiler opened this issue May 25, 2022 · 0 comments

Comments

@issuefiler
Copy link

I think this (.normalize("NFD")) should be optional.

Decomposing — yes, it’s for MacOS that decompose filename characters, but it comes with the obvious drawback: characters take more bytes than necessary. Hangul characters for example, get doubled or tripled in size, which means a filename can only have up to forty Hangul characters on average by your default maximum filename length MAX_FILENAME_LENGTH (100).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant