Account for extension length when truncating filename #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomasklaen
changed the title
👍 |
readme.md
Outdated
| @@ -59,6 +59,8 @@ Default: `100` | |||
|
|
|||
| Truncate the filename to the given length. | |||
|
|
|||
| Only filename is truncated, preserving the extension. If the extension itself is longer than `maxLength`, you'll get a string that is longer than requested, so you need to check for that. | |||
There was a problem hiding this comment.
Suggested change
| Only filename is truncated, preserving the extension. If the extension itself is longer than `maxLength`, you'll get a string that is longer than requested, so you need to check for that. | |
| Only the filename is truncated, preserving the extension. If the extension itself is longer than `maxLength`, you will get a string that is longer than `maxLength`, so you need to check for that if you allow arbitrary extensions. |
test.js
Outdated
| t.is(filenamify(path.basename(filename), {maxLength: 180}), 'very_very_very_very_very_very_very_very_very_very_very_very_very_very_very_very_very_very_very_very_very_very_very_very_very_very_very_long_filename.txt'); | ||
|
|
||
| // Extension longer than maxLength |
There was a problem hiding this comment.
Suggested change
| // Extension longer than maxLength | |
| // File extension longer than `maxLength` |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wasn't sure what to do with the filename when extension is loner than
maxLength, as removing it completely would create a dotfile which might have unintended consequences, so I decided to keep at least 1 character of the filename in place.Also found another bug: filenamify doesn't account for dotfiles, so this test:
Can't pass as other parts of filenamify remove the leading dot as they consider it a relative path, and than truncation later on treats it as a filename.
Separate PR? :)