Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve signature ordering detection requirements #518

Merged
merged 2 commits into from Dec 28, 2021
Merged

Improve signature ordering detection requirements #518

merged 2 commits into from Dec 28, 2021

Conversation

Borewit
Copy link
Collaborator

@Borewit Borewit commented Dec 28, 2021

Related to comment: "... this one need to move to the 3-byte signature".

Changes:

  1. Update PR guidelines
  2. Move .gif detection from 4 to 3 byte signature group
  3. Make ELF detection last test in 4 byte signature group rather then the last one

@Borewit
Improve signature ordering detection requirements
be7e3ef 
Fix order of `.gif` detection.
Make 'FLIF' last test in 4-byte signature group
@Borewit Borewit self-assigned this Dec 28, 2021
@sindresorhus sindresorhus merged commit d89a4a1 into main Dec 28, 2021
@sindresorhus sindresorhus deleted the detection-ordering branch December 28, 2021 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sindresorhus sindresorhus Awaiting requested review from sindresorhus

Assignees

@Borewit Borewit

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Borewit @sindresorhus