Add support for JPEG XL image format #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New version of JPEG, comes with a new bitstream and container.
The actual spec for the file format is behind an ISO paywall, but it's been finalized so it shouldn't ever change at this point.
I got the magic numbers from ImageMagick as well as the reference implementation, and the mime type
image/jxlfrom the provisional registration with IANASince the files come in 2 variants with quite different lengths for the header bytes I wasn't entirely sure where to add the checks, I decided to place them with the longest length variant.
And I added tests for both variants, and all tests pass locally for me.