Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for VCF (and fix ICS detection) #451

Merged
merged 6 commits into from May 5, 2021

Conversation

mdartic
Copy link
Contributor

@mdartic mdartic commented Apr 15, 2021

Link to the wiki page : https://en.wikipedia.org/wiki/VCard

If you're adding support for a new file type, please follow the below steps:

  • One PR per file type.
  • Add a fixture file named fixture.<extension> to the fixture directory.
  • Add the file extension to the extensions array in supported.js.
  • Add the file's MIME type to the types array in supported.js.
  • Add the file type detection logic to the core.js file.
  • Add the file extension to the FileType type in core.d.ts.
  • Add the file's MIME type to the MimeType type in core.d.ts.
  • Add the file extension to the Supported file types section in the readme, in the format - [`<extension>`](URL) - Format name, for example, - [`png`](https://en.wikipedia.org/wiki/Portable_Network_Graphics) - Portable Network Graphics
  • Add the file extension to the keywords array in the package.json file.
  • Run $ npm test to ensure the tests pass.
  • Open a pull request with a title like Add support for Format, for example, Add support for PNG.
  • The pull request description should include a link to the official page of the file format or some other source. Also include a link to where you found the file type detection / magic bytes and the MIME type.

Copy link
Collaborator

@Borewit Borewit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file tests are sorted on required initial sample length.
As the sample length now increased you need to move it further down.
That allows progressive reading.

core.js Outdated Show resolved Hide resolved
@Borewit Borewit requested a review from sindresorhus May 4, 2021 17:12
@sindresorhus sindresorhus merged commit 29618c8 into sindresorhus:main May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants