Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for XCF #450

Merged
merged 2 commits into from Apr 17, 2021
Merged

Add support for XCF #450

merged 2 commits into from Apr 17, 2021

Conversation

somebody1234
Copy link
Contributor

I have done a npm run test.

  • Mimetype from Wikipedia.
  • Magic bytes from GNOME docs - can add version number validation if needed considering the magic bytes are all ASCII
  • "Partial spec" - from Wkipedia

Borewit
Borewit requested changes Apr 15, 2021
View reviewed changes
readme.md Outdated Show resolved Hide resolved
core.js Outdated Show resolved Hide resolved
Borewit
Borewit approved these changes Apr 17, 2021
View reviewed changes
Copy link
Collaborator

@Borewit Borewit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sindresorhus sindresorhus merged commit 6ab25f3 into sindresorhus:main Apr 17, 2021
@somebody1234 somebody1234 deleted the feature-ext-xcf branch April 17, 2021 11:52
@somebody1234 somebody1234 mentioned this pull request Apr 17, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Borewit Borewit Borewit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@somebody1234 @Borewit @sindresorhus