Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support: lz4 and avro file-types #444

Open
jmealo opened this issue Mar 29, 2021 · 3 comments
Open

Support: lz4 and avro file-types #444

jmealo opened this issue Mar 29, 2021 · 3 comments

Comments

@jmealo
Copy link

jmealo commented Mar 29, 2021

Hello, great work so far! Thanks for another great module :)

I tested with fromFile and fromStream and .lz4 and .avro files are not properly detected.

LZ4 Magic Number:
4 Bytes, Little endian format. Value : 0x184D2204
https://fuchsia.googlesource.com/third_party/lz4/+/HEAD/doc/lz4_Frame_format.md

AVRO Magic Number:
Four bytes, ASCII 'O', 'b', 'j', followed by 1
http://avro.apache.org/docs/current/spec.html#Object+Container+Files

@somebody1234
Copy link
Contributor

just tested on 7-zip, its lz4s start with 502a 4d18 instead of 0422 4d18

@IgorWiecz
Copy link
Contributor

I've opened up a PR for the avro file type support:
#597

@IgorWiecz
Copy link
Contributor

lz4
https://github.com/lz4/lz4/blob/dev/doc/lz4_Frame_format.md
4 Bytes, Little endian format. Value : 0x184D2204

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants