Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the MPEG/ADTS frame / ID3 detection algorithm #210

Closed
Borewit opened this issue May 5, 2019 · 1 comment
Closed

Improve the MPEG/ADTS frame / ID3 detection algorithm #210

Borewit opened this issue May 5, 2019 · 1 comment
Labels
enhancement help wanted

Comments

@Borewit
Copy link
Collaborator

Borewit commented May 5, 2019 •
edited

  • Don't scan ID3 at odd offset's
  • Prevent false positives
  • Scan for actual format coming after ID3 tag header

Related issues:
@Borewit Borewit changed the title Improve the MPEG frame / ID3 detection algorithm Improve the MPEG/ADTS frame / ID3 detection algorithm May 5, 2019
@Borewit Borewit mentioned this issue May 5, 2019
Closed
@Borewit Borewit mentioned this issue Oct 15, 2019
Closed
6 tasks
@Borewit
Copy link
Collaborator Author

Borewit commented Dec 3, 2019 •
edited

#248 should solve solved this.

@Borewit Borewit mentioned this issue Dec 3, 2019
Closed
@Borewit Borewit closed this as completed Jan 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sindresorhus @Borewit