Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix problems with third-party Promise #427

Merged
merged 5 commits into from May 22, 2020

Conversation

fisker
Copy link
Contributor

@fisker fisker commented May 22, 2020

Fixes #426

@fisker fisker force-pushed the broken-on-thirdparty-promise branch from c5e28c6 to 3b3596d Compare May 22, 2020 02:52
@fisker fisker force-pushed the broken-on-thirdparty-promise branch from 68c7ca9 to 7fe9e0c Compare May 22, 2020 03:10
@fisker fisker marked this pull request as ready for review May 22, 2020 03:10
@ehmicky
Copy link
Collaborator

ehmicky commented May 22, 2020

Looks good, thanks!
Waiting for review from @sindresorhus too.

@ehmicky ehmicky self-requested a review May 22, 2020 11:53
@sindresorhus sindresorhus merged commit 96ad152 into sindresorhus:master May 22, 2020
@fisker fisker deleted the broken-on-thirdparty-promise branch May 22, 2020 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4.0.1 causes problems with Bluebird
3 participants