Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add retry example to Tips readme section #386

Merged
merged 6 commits into from Nov 8, 2019

Conversation

justsml
Copy link
Contributor

@justsml justsml commented Nov 2, 2019

Fixes #362

This addresses a need I had.

@ehmicky
Copy link
Collaborator

ehmicky commented Nov 3, 2019

Thanks @justsml for this PR!

I like the idea. However I am not so sure about referring to that specific library promise-retry. It seems like it has not received any commits for quite some time, and PR/issues are not processed anymore.

On the other hand, a library like p-retry is maintained and has more features. What do you think?

@justsml
Copy link
Contributor Author

justsml commented Nov 3, 2019

Strong agree @ehmicky ... I'll get it updated. 🤘

@ehmicky
Copy link
Collaborator

ehmicky commented Nov 4, 2019

This looks good now, thanks! @sindresorhus what do you think?

@sindresorhus
Copy link
Owner

Retry on Error => Retry on error

@justsml
Copy link
Contributor Author

justsml commented Nov 8, 2019

Fixed title: 'Error' => 'error'

@sindresorhus sindresorhus changed the title Adds retry example to Tips readme section Add retry example to Tips readme section Nov 8, 2019
@sindresorhus sindresorhus merged commit ecdbad3 into sindresorhus:master Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: handle EAGAIN
3 participants