Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename internal variables #379

Merged
merged 1 commit into from
Oct 17, 2019
Merged

Rename internal variables #379

merged 1 commit into from
Oct 17, 2019

Conversation

ehmicky
Copy link
Collaborator

@ehmicky ehmicky commented Oct 16, 2019

This renames internal variables used in tests to make them more consistent and avoid abbreviations:

  • child, cp -> subprocess
  • s -> stream
  • ee -> emitter

@ehmicky ehmicky mentioned this pull request Oct 16, 2019
Merged
@sindresorhus sindresorhus merged commit 1ac56ea into master Oct 17, 2019
@sindresorhus sindresorhus deleted the refactor/rename-variable branch October 17, 2019 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ehmicky @sindresorhus