Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider allowing windowsHide option #371

Closed
jabrown85 opened this issue Oct 4, 2019 · 3 comments · Fixed by #388
Closed

Consider allowing windowsHide option #371

jabrown85 opened this issue Oct 4, 2019 · 3 comments · Fixed by #388

Comments

@jabrown85
Copy link

See nodejs/node#29837 for why this option can make a practical difference. I saw the previous discussion on #242 that was closed because there wasn't a known reason to allow it.

@ehmicky
Copy link
Collaborator

ehmicky commented Oct 4, 2019

Hi @jabrown85! Thanks for filling this issue.

Yes that makes sense.

TLDR: without windowsHide: false on Windows, CTRL-C does not work. So we should still default it to true but allow users to override it to false.

@sindresorhus what do you think?

@sindresorhus
Copy link
Owner

Sure, as long as we clearly document in what specific scenarios it might be useful.

@ehmicky
Copy link
Collaborator

ehmicky commented Nov 9, 2019

Done at #388.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants