Do not read streams more than once #330
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #327
Fixes #321
We read the
stdout
,stderr
andall
streams to make them available as a string/buffer to users. We defer it (we wait forexecaResult.then()
to be called) in case users prefer consuming those streams themselves.However if
execaResult.then()
is called twice:execaResult.then()
should just follow the same promise.pump
, which leads to a memory leak and warnings in the console.Arguably users should not call
execaResult.then()
several times. However this might happen whenexecaResult
is passed from consumer to consumer, with each consumer doing its own (possibly delayed) logic with it.This PR fixes this problem by ensuring the streams consumption function is only called once, using the small utility
onetime
.