Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Execa fails to handle numeric error codes in Node 8 #320

Closed
Lalem001 opened this issue Jun 25, 2019 · 3 comments
Closed

Execa fails to handle numeric error codes in Node 8 #320

Lalem001 opened this issue Jun 25, 2019 · 3 comments

Comments

@Lalem001
Copy link

Per node's docs, util.getSystemErrorName was added in Node 9.7.0.

util.getSystemErrorName appears in Execa's lib/error.js#L11.

I see the following error in Node 8.9.4,

TypeError {
  message: 'util.getSystemErrorName is not a function',
}
@Lalem001 Lalem001 changed the title Execa fails to handle numeric error codes Execa fails to handle numeric error codes in Node 8 Jun 25, 2019
@sindresorhus
Copy link
Owner

You're on an ancient Node.js 8 version. You have to upgrade. There have been a lot of feature and security bug fixes since then.

#319

@Lalem001
Copy link
Author

I wholeheartedly agree. Your opinion might just be enough to get my company to upgrade 😆

Thanks for #319

@ehmicky
Copy link
Collaborator

ehmicky commented Jun 25, 2019

@Lalem001 util.getSystemErrorName() was backported to Node 8.12.0. I hope you are able to upgrade to that Node version in your company.

We just updated the engines field (as you pointed out) to make our supported Node versions clearer. Thanks for checking out the new release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants