Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update engines field in package.json #319

Merged
merged 1 commit into from Jun 25, 2019

Conversation

ehmicky
Copy link
Collaborator

@ehmicky ehmicky commented Jun 25, 2019

Fixes #318 (with some background in #221).

We are using util.getSystemErrorName() which has been added to Node 9.7.0 then backported to 8.12.0. At the moment users with let's say Node 8.10.0 are not warned during installation that we don't support them. They discover it when running execa and have to dig to understand what's wrong. Adding the proper semver in engines field would prevent some frustration for those users.

@sindresorhus sindresorhus merged commit 8663361 into master Jun 25, 2019
@sindresorhus sindresorhus deleted the feature/update-engines-field branch June 25, 2019 18:58
ybiquitous added a commit to ybiquitous/ybiq that referenced this pull request Jul 2, 2019
BREAKING CHANGE: `execa@2.0.2`, which `lint-staged@9` depends on, requires Node 8.12 at minimum

See also sindresorhus/execa#319
ybiquitous added a commit to ybiquitous/ybiq that referenced this pull request Jul 2, 2019
BREAKING CHANGE: `execa@2.0.2`, which `lint-staged@9` depends on, requires Node 8.12 at minimum

See also sindresorhus/execa#319
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

util.getSystemErrorName not available before Node v9.7.0
2 participants