Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util.getSystemErrorName not available before Node v9.7.0 #318

Closed
luca-aurelia opened this issue Jun 25, 2019 · 3 comments Β· Fixed by #319
Closed

util.getSystemErrorName not available before Node v9.7.0 #318

luca-aurelia opened this issue Jun 25, 2019 · 3 comments Β· Fixed by #319

Comments

@luca-aurelia
Copy link

Hi folks,

Thanks for all the time and hard work you put into this package. I know open source is often thankless, so I want to take a second to say that I really appreciate what you do πŸ˜„

Okay, bug report time β€’ while running execa on Node v8.11.1, I ran into this error:

TypeError: util.getSystemErrorName is not a function

I did a little research and I think this is what's happening:

In error.js, you make a call to util.getSystemErrorName. According to the Node docs, this function wasn't added until Node v9.7.0, but the engines field in your package.json specifies any Node version >= 8.

Hope this is clear! Let me know if I can provide more details or help with anything else.

Cheers,
Thomas

@ehmicky
Copy link
Collaborator

ehmicky commented Jun 25, 2019

Hi Thomas, thanks for reaching out! Thanks for the kind words as well!

We support >=8.12.0. util.getSystemErrorName() was backported to 8.12.0.

See here on the discussion related to the engines field, and let me know what you think.

@luca-aurelia
Copy link
Author

luca-aurelia commented Jun 25, 2019

Okay, perfect. I figured there was something I was missing. (And thanks for the lightning fast response πŸ˜‚)

Is it worth updating the engines field to indicate that only 8.12 and up are supported?

@ehmicky
Copy link
Collaborator

ehmicky commented Jun 25, 2019

I think so (PR at #319) but I am not sure how @sindresorhus feels about this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants