Fix shape of exceptions thrown by execa.sync()
#277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When some options like
timeoutare invalid,child_process.spawnSync()throws synchronously. When this happens, the exception thrown does not use the same shape as the other execa errors.This PR fixes this.
Note: the options that make
child_process.spawnSync()andchild_process.spawn()throw are different. For exampleuid: -1makesspawn()throw but notspawnSync(). This is the opposite fortimeout: -1. Because of this, the tests were wrong, which is why this bug was not caught.