Remove error.code
#250
Merged
Remove error.code
#250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let's just remove it completely. You were right. It's confusing and weird to have it now that we have the other properties. |
ehmicky
force-pushed
the
feature/remove-code-in-typescript
branch
from
b77e9ff
to
1f427fd
Compare
ehmicky
changed the title
error.code in TypeScript definitionserror.code
|
Line 425 in 1f427fd |
|
That's because for some reason
I agree it looks bad though, I refactored it. |
This was referenced May 15, 2019
Merged
stianjensen
added a commit
to stianjensen/react-native-community-cli
that referenced
this pull request
Mar 27, 2023
https://github.com/sindresorhus/execa/releases 5.x is the last version before the package is being rewritten to ESM. execa now ships with typescript types embedded. I see a previous attempt here was aborted: react-native-community#1514 Relevant breaking changes: error.code is deprecated in favor of error.exitCode sindresorhus/execa#250 Some changes to stripping the final newline: sindresorhus/execa@f8397ba
adamTrz
pushed a commit
to react-native-community/cli
that referenced
this pull request
Mar 28, 2023
https://github.com/sindresorhus/execa/releases 5.x is the last version before the package is being rewritten to ESM. execa now ships with typescript types embedded. I see a previous attempt here was aborted: #1514 Relevant breaking changes: error.code is deprecated in favor of error.exitCode sindresorhus/execa#250 Some changes to stripping the final newline: sindresorhus/execa@f8397ba
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
error.codeis deprecated in favor oferror.exitCodeanderror.exitCodeName. This PR removes it from the TypeScript definition.I am not sure whether unknown properties are an issue with TypeScript. If they are, feel free to close this PR.