Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove compatibility layer for util.getSystemErrorName() #221

Merged
merged 2 commits into from May 7, 2019

Conversation

ehmicky
Copy link
Collaborator

@ehmicky ehmicky commented May 7, 2019

Although the Node.js documentation says that util.getSystemErrorName() is added in 9.7.0, it's actually been back-ported 6 months later to 8.12.0. I tried it with nvm and confirm this function works in 8.12.0.

We use a compatibility layer for this function, which can now be removed.

I am a little unclear whether we support 8.0.0 to 8.11.0, or only the later 8.*.* versions:

  • the package.json engines.node field shows >=8, which is translated by npm to >=8.0.0 (using semver under the hood).
  • but the version tested on Travis is 8, which is translated to the latest 8.16.0 (using nvm under the hood).

(I think those two should be in sync, but that's a separate issue).

As a side effect, this would also fix test coverage there.

@sindresorhus
Copy link
Owner

I am a little unclear whether we support 8.0.0 to 8.11.0, or only the later 8.. versions:

Generally, it's expected that users upgrade patch versions as those contain important security fixes. We can continue this in sindresorhus/meta#8.

@sindresorhus sindresorhus merged commit 4cd3d35 into master May 7, 2019
@sindresorhus
Copy link
Owner

Yay. Feels good getting that removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants