Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate/remove execa.stdout() and execa.stderr() #220

Closed
ehmicky opened this issue May 7, 2019 · 2 comments · Fixed by #234
Closed

Deprecate/remove execa.stdout() and execa.stderr() #220

ehmicky opened this issue May 7, 2019 · 2 comments · Fixed by #234

Comments

@ehmicky
Copy link
Collaborator

ehmicky commented May 7, 2019

execa.stdout() and execa.stderr() are easy enough to reproduce with destructuring:

const { stdout } = await execa(...)

Removing those methods would make the API simpler, and reduce code size.

One potential benefit of execa.stdout() and execa.stderr() would be to pass ignore to the other standard output stream, which would make I/O faster. This is not implemented at the moment. This seems to me that this would be a micro-optimization, and easy enough to emulate by letting users explicitly pass that option.

Should those methods be removed or deprecated?

If so, I can submit a PR.

@sindresorhus
Copy link
Owner

Yes, let's do it.

@ehmicky
Copy link
Collaborator Author

ehmicky commented May 11, 2019

Done at #234

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants