Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace null by undefined #193

Merged
merged 2 commits into from Mar 19, 2019
Merged

Replace null by undefined #193

merged 2 commits into from Mar 19, 2019

Conversation

ehmicky
Copy link
Collaborator

@ehmicky ehmicky commented Mar 15, 2019 •
edited

Follow up of #191 (comment)

Replace all null by undefined.

null are still allowed as input for the options stdin, stdout, stderr, input and encoding to be compatible with the core Node.js API. But they are not produced in output for stdin, stdout, stderr and signal.

@ehmicky ehmicky mentioned this pull request Mar 15, 2019
Closed
@sindresorhus sindresorhus merged commit dca1504 into sindresorhus:master Mar 19, 2019
@ehmicky ehmicky deleted the feature/remove-null branch March 19, 2019 16:06
@sindresorhus sindresorhus mentioned this pull request Mar 19, 2019
Merged
@ehmicky ehmicky mentioned this pull request May 15, 2019
Closed
@dependabot dependabot bot mentioned this pull request Mar 14, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sindresorhus sindresorhus Awaiting requested review from sindresorhus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ehmicky @sindresorhus