From 036b504b76aec91ef824aba1db3e724704809d18 Mon Sep 17 00:00:00 2001 From: ehmicky Date: Sun, 28 Apr 2024 19:56:12 +0100 Subject: [PATCH] Fix PR commit status failing due to Codecov --- .github/workflows/main.yml | 3 +++ lib/arguments/options.js | 1 + 2 files changed, 4 insertions(+) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index e4250576cd..c588806ba1 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -24,6 +24,9 @@ jobs: - run: npm install - run: npm test - uses: codecov/codecov-action@v4 + # Codecov merges results too early, which makes it not report Windows test coverage. + # This makes the PR commit status fail. + if: matrix.os == 'ubuntu' && matrix.node-version == 20 with: token: ${{ secrets.CODECOV_TOKEN }} flags: '${{ matrix.os }}, node-${{ matrix.node-version }}' diff --git a/lib/arguments/options.js b/lib/arguments/options.js index ec785349a0..6826008153 100644 --- a/lib/arguments/options.js +++ b/lib/arguments/options.js @@ -29,6 +29,7 @@ export const normalizeOptions = (filePath, rawArguments, rawOptions) => { if (process.platform === 'win32' && basename(file, '.exe') === 'cmd') { // #116 + /* c8 ignore next */ commandArguments.unshift('/q'); }