diff --git a/rules/prefer-string-replace-all.js b/rules/prefer-string-replace-all.js index 5e80f9bc35..b755fc80a9 100644 --- a/rules/prefer-string-replace-all.js +++ b/rules/prefer-string-replace-all.js @@ -9,7 +9,7 @@ const MESSAGE_ID_USE_REPLACE_ALL = 'method'; const MESSAGE_ID_USE_STRING = 'pattern'; const messages = { [MESSAGE_ID_USE_REPLACE_ALL]: 'Prefer `String#replaceAll()` over `String#replace()`.', - [MESSAGE_ID_USE_STRING]: 'This pattern can be replaced with a string {{replacement}}.', + [MESSAGE_ID_USE_STRING]: 'This pattern can be replaced with {{replacement}}.', }; const selector = methodCallSelector({ @@ -97,7 +97,7 @@ const create = context => ({ messageId: MESSAGE_ID_USE_STRING, data: { // Show `This pattern can be replaced with a string literal.` for long strings - replacement: patternReplacement.length < 20 ? patternReplacement : 'literal', + replacement: patternReplacement.length < 20 ? patternReplacement : 'a string literal', }, /** @param {import('eslint').Rule.RuleFixer} fixer */ fix: fixer => fixer.replaceText(pattern, patternReplacement), diff --git a/test/prefer-string-replace-all.mjs b/test/prefer-string-replace-all.mjs index 1ac58c935d..d8226d698d 100644 --- a/test/prefer-string-replace-all.mjs +++ b/test/prefer-string-replace-all.mjs @@ -102,6 +102,6 @@ test.snapshot({ 'foo.replaceAll(/a]/g, _)', 'foo.replaceAll(/\\r\\n\\u{1f600}/gu, _)', - `foo.replaceAll(/a${' very'.repeat(30)} string/g, _)`, + `foo.replaceAll(/a${' very'.repeat(30)} long string/g, _)`, ], }); diff --git a/test/snapshots/prefer-string-replace-all.mjs.md b/test/snapshots/prefer-string-replace-all.mjs.md index 1bc94d70d9..56aa976f28 100644 --- a/test/snapshots/prefer-string-replace-all.mjs.md +++ b/test/snapshots/prefer-string-replace-all.mjs.md @@ -579,7 +579,7 @@ Generated by [AVA](https://avajs.dev). `␊ > 1 | foo.replaceAll(/a]/g, _)␊ - | ^^^^^ This pattern can be replaced with a string 'a]'.␊ + | ^^^^^ This pattern can be replaced with 'a]'.␊ ` ## Invalid #36 @@ -595,21 +595,21 @@ Generated by [AVA](https://avajs.dev). `␊ > 1 | foo.replaceAll(/\\r\\n\\u{1f600}/gu, _)␊ - | ^^^^^^^^^^^^^^^^^ This pattern can be replaced with a string '\\r\\n😀'.␊ + | ^^^^^^^^^^^^^^^^^ This pattern can be replaced with '\\r\\n😀'.␊ ` ## Invalid #37 - 1 | foo.replaceAll(/a very very very very very very very very very very very very very very very very very very very very very very very very very very very very very very string/g, _) + 1 | foo.replaceAll(/a very very very very very very very very very very very very very very very very very very very very very very very very very very very very very very long string/g, _) > Output `␊ - 1 | foo.replaceAll('a very very very very very very very very very very very very very very very very very very very very very very very very very very very very very very string', _)␊ + 1 | foo.replaceAll('a very very very very very very very very very very very very very very very very very very very very very very very very very very very very very very long string', _)␊ ` > Error 1/1 `␊ - > 1 | foo.replaceAll(/a very very very very very very very very very very very very very very very very very very very very very very very very very very very very very very string/g, _)␊ - | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ This pattern can be replaced with a string literal.␊ + > 1 | foo.replaceAll(/a very very very very very very very very very very very very very very very very very very very very very very very very very very very very very very long string/g, _)␊ + | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ This pattern can be replaced with a string literal.␊ ` diff --git a/test/snapshots/prefer-string-replace-all.mjs.snap b/test/snapshots/prefer-string-replace-all.mjs.snap index 1ba0cdf437..aa0b930b23 100644 Binary files a/test/snapshots/prefer-string-replace-all.mjs.snap and b/test/snapshots/prefer-string-replace-all.mjs.snap differ