Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deprecated rules #968

Merged
merged 2 commits into from Dec 29, 2020
Merged

Fix deprecated rules #968

merged 2 commits into from Dec 29, 2020

Conversation

fisker
Copy link
Collaborator

@fisker fisker commented Dec 29, 2020

I was stupid, forgot to return rules in createDeprecatedRules function.

@sindresorhus sindresorhus merged commit 9921acc into sindresorhus:master Dec 29, 2020
@sindresorhus
Copy link
Owner

What are the implications of this? Is it a breaking change now?

@fisker
Copy link
Collaborator Author

fisker commented Dec 29, 2020 •
edited

I think this fix v25, if people have deprecated rules in config or eslint-disabled there were errors(can't find rule), this fix that.

@fisker fisker deleted the deprecated-rules branch December 29, 2020 23:48
sindresorhus pushed a commit that referenced this pull request Dec 30, 2020
@fisker @sindresorhus
Fix deprecated rules (#968)
c898f7a
@dependabot dependabot bot mentioned this pull request Mar 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fisker @sindresorhus