Add empty-brace-spaces rule
#933
Conversation
fisker
force-pushed
the
empty-brace-space
branch
2 times, most recently
from
db4003e
to
a99a89d
Compare
fisker
force-pushed
the
empty-brace-space
branch
2 times, most recently
from
fbd2115
to
c50ebe7
Compare
fisker
force-pushed
the
empty-brace-space
branch
from
c50ebe7
to
418f187
Compare
| [MESSAGE_ID]: 'Do not add spaces between braces.' | ||
| }; | ||
|
|
||
| const selector = `:matches(${ |
There was a problem hiding this comment.
Isn't it easier to just do this?
const selector = ":matches(BlockStatement[body.length=0], ClassBody[body.length=0], ObjectExpression[properties.length=0])"There was a problem hiding this comment.
Yes, same. But I prefer current one, it's more readable add diff friendly, if we want add more.
const selector = `:matches(${
[
'BlockStatement[body.length=0]',
'ClassBody[body.length=0]',
+ 'ImportNamespaceSpecifier[assertions.length=0]',
'ObjectExpression[properties.length=0]'
].join(', ')
})`;VS
- const selector = ":matches(BlockStatement[body.length=0], ClassBody[body.length=0], ObjectExpression[properties.length=0])"
+ const selector = ":matches(BlockStatement[body.length=0], ClassBody[body.length=0], ImportNamespaceSpecifier[assertions.length=0], ObjectExpression[properties.length=0])"
| 'function foo(){/* */}', | ||
| 'foo = {/* */}', | ||
| 'class Foo {bar() {/* */}}', | ||
| 'foo = class {bar() {/* */}}' |
There was a problem hiding this comment.
We also need to test for () => {}.
There was a problem hiding this comment.
rules/empty-brace-spaces.js
Outdated
| }; | ||
| }; | ||
|
|
||
| const schema = []; |
There was a problem hiding this comment.
I don't see the point of adding empty schema.
There was a problem hiding this comment.
It's in template, forgot to remove.
BTW: Do you know eslint-plugin-eslint-plugin not working on our rules? And actually this is enforced by it.
Even when there are no options for a rule, a schema should still be defined (as an empty array) so that eslint can validate that no data is passed to the rule.
There was a problem hiding this comment.
Not sure why it didn't catch this. It has caught issues in the past though.
I renamed
empty-brace-spacetoempty-brace-spaces, consistent withno-console-spacesrule name.Fixes #900