Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

string-content: Ignore some TaggedTemplateExpression #585

Merged
merged 4 commits into from Mar 11, 2020

Conversation

fisker
Copy link
Collaborator

@fisker fisker commented Mar 10, 2020

Ignored gql`...` (requested in xojs/xo#439 (comment)) and styled.*`...`, anything else?

Edit: add html`...` and svg`...`

@fisker fisker force-pushed the string-content-ignore-tags branch from 5e969b5 to 6afe4fc Compare March 10, 2020 04:42
@sindresorhus
Copy link
Owner

// @fregante

@sindresorhus
Copy link
Owner

@fisker Can you quickly mention in the docs the tagged template literals we ignore?

@fisker fisker force-pushed the string-content-ignore-tags branch 2 times, most recently from d92459f to 16f59c5 Compare March 11, 2020 06:13
@fisker fisker force-pushed the string-content-ignore-tags branch from 16f59c5 to 982454c Compare March 11, 2020 06:13
@sindresorhus sindresorhus changed the title string-content: ignore some TaggedTemplateExpression string-content: Ignore some TaggedTemplateExpression Mar 11, 2020
@sindresorhus sindresorhus merged commit 92f3f3d into sindresorhus:master Mar 11, 2020
@fisker fisker deleted the string-content-ignore-tags branch March 11, 2020 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants