-
-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expiring-todo-comments
should include the comment itself in the report
#401
Comments
// @lubien In case you're interested in working on this. |
I would go for the short version:
|
I can work on this weekend, sure!
Noted. How long until clip? I could use something like lubien@heron:~/dev$ npx eslint Untitled-1.js
~/dev/foo.js
1:1 error Unexpected 'todo' comment unicorn/expiring-todo-comments
✖ 1 problem (1 errors, 0 warnings)
lubien@heron:~/dev$ node
> process.stdout.columns
103 Given 103 column digits. For this case I can see 4 digits for reporting level, a few for How about making messages at most 50% |
We can’t depend on process.stdout.columns as we can’t know how the reporter will format it. We just have to decide on an arbitrary (large) limit and truncate. |
@lubien Are you still interested in working on this? No pressure at all. Just want to open this issue up for other if you're busy :) |
@sindresorhus Interested for sure but I'm afraid my free time wont be enough for a couple weeks or so. Sorry for delaying this but would be best if we open this issue for another person for now but I'm eager to return contributing soon anytime by December so whenever I can help please tag me. |
FYI, this was implemented and released in eslint: eslint/eslint#12327 |
I'm updating dependencies in #816 |
Copied from eslint/eslint#12327
I think the point of this rule is to keep track of TODO comments, however this is hard to follow; I'd have to open each file separately to see if I can handle a task.
Current
Ideal
Or
The text was updated successfully, but these errors were encountered: