Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New integration test #1906

Merged
merged 42 commits into from Sep 21, 2022
Merged

New integration test #1906

merged 42 commits into from Sep 21, 2022

Conversation

fisker
Copy link
Collaborator

@fisker fisker commented Sep 20, 2022

  1. Use ESLint API instead of CLI to run test
  2. Improved log
  3. Speed up by spliting into groups

@fisker
Copy link
Collaborator Author

fisker commented Sep 20, 2022

The ts parser is so damn slow, took 11min to lint 500 files https://github.com/sindresorhus/eslint-plugin-unicorn/actions/runs/3089488168/jobs/4997163035#step:5:83

@fisker
Copy link
Collaborator Author

fisker commented Sep 20, 2022

Missing ruleId in message eslint/eslint#16333

@fisker
Copy link
Collaborator Author

fisker commented Sep 20, 2022

Missing ruleId in message eslint/eslint#16333

Mistake, there is no ruleId if it's a syntax error https://github.com/eslint/eslint/blob/2c152ff0fb709b99e62c19ecd2c95689efacbe4c/lib/linter/linter.js#L845, I guess ESLint can't trace which rule cause that invalid fix.

@fisker fisker marked this pull request as ready for review September 20, 2022 15:11
@sindresorhus sindresorhus merged commit 3a1e1bc into sindresorhus:main Sep 21, 2022
@sindresorhus
Copy link
Owner

Very nice! 🎉

@fisker fisker deleted the integration-test branch September 21, 2022 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants