Make template-indent preserve trailing spaces
#1872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fisker
reviewed
Sep 19, 2022
| @@ -67,9 +67,11 @@ const create = context => { | |||
| } | |||
|
|
|||
| const dedented = stripIndent(joined); | |||
| const trimmed = dedented.replace(new RegExp(`^${eol}|${eol}[ \t]*$`, 'g'), ''); | |||
There was a problem hiding this comment.
I don't think this is correct.
It should only remove leading/trailing empty new lines.
There was a problem hiding this comment.
@fisker This is the way it is already working and I was not sure if we should alter the existing behavior because it would be a breaking change
There was a problem hiding this comment.
Somehow I missed space in the regexp, it's good.
fisker
approved these changes
Sep 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1868
I realized that having it as a setting is not a right thing, because linter fixes should be essentially the same code, just restyled. Trimming trailing spaces essentially modifies the string and this should be considered as a bug.
Corresponding unit tests were added