unicorn/prefer-export-from breaks type exports in typescript projects using the isolatedModules flag.

[nrgnrg]

When autofixing exports in ts projects unicorn/prefer-export-from will change this:

import UIAvatar, {
  UIAvatarProps,
} from "./UIAvatar";

export type { UIAvatarProps };
export default UIAvatar;

into

export { default, UIAvatarProps } from "./UIAvatar";

Which results in a typescript error Re-exporting a type when the '--isolatedModules' flag is provided requires using 'export type'.ts(1205)

The correct fix should be:

export { default, type UIAvatarProps } from "./UIAvatar";

Type only exports should be prefixed with type.

I've also seen this problem happen the other way around before where a non type export gets bundled into an export type { ... } from "" and has broken internal library code as the autofix is applied using commit hooks.

[fisker]

PR welcome.

[fisker]

We need add something like kind: 'value' | 'type' to

eslint-plugin-unicorn/rules/prefer-export-from.js

Line 209 in e8ab176

function getImported(variable, sourceCode) {

and

eslint-plugin-unicorn/rules/prefer-export-from.js

Line 151 in e8ab176

function getExported(identifier, context, sourceCode) {

[nrgnrg]

Hey @fisker, I wasn't too sure how to approach this but after having a quick poke around I think I've found a rather simple solution.

Have raised a PR, let me know how it looks to you #1728