Add an internal ESLint rule prefer-negative-boolean-attribute
#1725
+82
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fisker
changed the title
prefer-negative-boolean-attributeprefer-negative-boolean-attribute
silverwind
reviewed
Feb 11, 2022
| @@ -74,6 +74,7 @@ | |||
| "eslint": "^8.6.0", | |||
| "eslint-ava-rule-tester": "^4.0.0", | |||
| "eslint-plugin-eslint-plugin": "^4.1.0", | |||
| "eslint-plugin-internal-rules": "file:./scripts/internal-rules/", | |||
There was a problem hiding this comment.
Does eslint not offer a way to load a plugin from a file instead of a module?
There was a problem hiding this comment.
This being a loooong story, and the reason is ridiculous, add a plugin path in config, ESLint can't get a plugin name to use...
Unless you use the ESLint API, you can't add plugin in other way.
There was a problem hiding this comment.
You could hack the module resolution like node core does but i guess it's even worse of a hack 😉.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use positive
[...=true]may cause problems, whenecmaVersionis not correct. #1146, fisker/eslint-plugin-prettier-doc@f1b1c6fMaybe I can try to make a proposal in eslint-plugin-eslint-plugin later.