Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no-array-callback-reference: remove superfluous argument #1692

Merged
merged 2 commits into from Jan 14, 2022
Merged

no-array-callback-reference: remove superfluous argument #1692

merged 2 commits into from Jan 14, 2022

Conversation

XhmikosR
Copy link
Contributor

@XhmikosR XhmikosR commented Jan 14, 2022

Spotted on https://lgtm.com/projects/g/sindresorhus/eslint-plugin-unicorn/?mode=list

Needs confirmation if it's really unused or it was supposed to do something else :)

@XhmikosR XhmikosR marked this pull request as ready for review January 14, 2022 09:03
@fisker
Copy link
Collaborator

fisker commented Jan 14, 2022

This should blame on me, the parameter is removed during refactoring

We can use it on

const sourceCode = context.getSourceCode();

@fisker
Copy link
Collaborator

fisker commented Jan 14, 2022

#666 introduced it.

@XhmikosR
Copy link
Contributor Author

Not sure about that, I just noticed the warning and thought I'd make a PR for someone more familiar with the codebase to have a look.

Feel free to push here or close this and take care of it yourself :)

Copy link
Collaborator

@fisker fisker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep it this way, thank you!

@fisker fisker changed the title no-array-callback-reference: remove superfluous argument no-array-callback-reference: remove superfluous argument Jan 14, 2022
@fisker fisker merged commit 0a81ce5 into sindresorhus:main Jan 14, 2022
@XhmikosR XhmikosR deleted the patch-1 branch January 14, 2022 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants