Add no-thenable rule
#1616
Merged
Add no-thenable rule
#1616
+1,310
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sindresorhus
requested changes
Nov 23, 2021
docs/rules/no-thenable.md
Outdated
|
|
||
| ✅ *This rule is part of the [recommended](https://github.com/sindresorhus/eslint-plugin-unicorn#recommended-config) config.* | ||
|
|
||
| If an object is defined as "thenable", once it's accidentally used in an await expression, it may cause problems. |
There was a problem hiding this comment.
It should describe what kind of problem.
bmish
reviewed
Nov 24, 2021
docs/rules/no-thenable.md
Outdated
|
|
||
| ✅ *This rule is part of the [recommended](https://github.com/sindresorhus/eslint-plugin-unicorn#recommended-config) config.* | ||
|
|
||
| If an object is defined as "thenable", once it's accidentally used in an await expression, it may cause problems. |
There was a problem hiding this comment.
Any docs to link to about this for context?
There was a problem hiding this comment.
I can't find any link for this.
Co-authored-by: Sindre Sorhus <sindresorhus@gmail.com>
|
I've added some example to show the problems. |
fisker
commented
Dec 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1596