Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jsdoc type to externally-exported rules #1613

Merged
merged 1 commit into from Nov 18, 2021

Conversation

bmish
Copy link
Sponsor Collaborator

@bmish bmish commented Nov 17, 2021

Adds a much more useful and complete type to the rules exported by this package. This would benefit anyone manually importing the rules from this package (side note: I'm not really sure of use cases for someone to do that, but this can't hurt).

Before After
Screen Shot 2021-11-16 at 7 34 24 PM Screen Shot 2021-11-16 at 7 33 40 PM

jsdoc types can provide autocomplete and even type-checking: https://medium.com/@trukrs/type-safe-javascript-with-jsdoc-7a2a63209b76

@sindresorhus sindresorhus merged commit 2e22382 into sindresorhus:main Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants