Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove require-post-message-target-origin rule from recommended config #1581

Merged

Conversation

fisker
Copy link
Collaborator

@fisker fisker commented Nov 8, 2021

Close #1396
Close #1552
Close #1578

@fisker fisker changed the title Turn of require-post-message-target-origin rule in recommended configs by default Turn off require-post-message-target-origin rule in recommended configs Nov 8, 2021
@fisker fisker changed the title Turn off require-post-message-target-origin rule in recommended configs Remove require-post-message-target-origin rule from recommended config Nov 8, 2021
@sindresorhus sindresorhus merged commit 014b4dc into sindresorhus:main Nov 8, 2021
@fisker fisker deleted the require-post-message-target-origin-off branch November 8, 2021 10:45
@jdanil
Copy link
Contributor

jdanil commented Nov 22, 2021

Just FYI, this rule is still flagged as recommended in the rule's doc file.
https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/require-post-message-target-origin.md?plain=1#L3

@fisker
Copy link
Collaborator Author

fisker commented Nov 22, 2021

@bmish Can you add a test for that?

@bmish
Copy link
Sponsor Collaborator

bmish commented Nov 23, 2021

@fisker there was a test for that already but there was a bug in it, fixed: #1619

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants