Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add allconfig #1512

Merged
merged 10 commits into from Sep 11, 2021
Merged

Add allconfig #1512

merged 10 commits into from Sep 11, 2021

Conversation

Yash-Singh1
Copy link
Contributor

Fixes #1510

@Yash-Singh1 Yash-Singh1 marked this pull request as draft September 6, 2021 03:07
@Yash-Singh1
Copy link
Contributor Author

@Yash-Singh1 Yash-Singh1 marked this pull request as ready for review September 6, 2021 22:10
index.js Outdated Show resolved Hide resolved
@sindresorhus
Copy link
Owner

You need to add the configs directory to package.json

@Yash-Singh1
Copy link
Contributor Author

Applied suggestions in b79b233

@AriPerkkio
Copy link
Contributor

Coverage of smoke tests could now be increased.

extends: ['plugin:unicorn/recommended'],

- extends: ['plugin:unicorn/recommended'], 
+ extends: ['plugin:unicorn/all'], 

(It would also be great to include there even the rules which require options but that's out of scope here)

@sindresorhus sindresorhus merged commit a512ad1 into sindresorhus:main Sep 11, 2021
manovotny pushed a commit to manovotny/eslint-plugin-unicorn that referenced this pull request Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Export an all config
4 participants