Add prefer-array-flat rule
#1126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Half code in this rule just esquery selector. 😄 |
sindresorhus
requested changes
Feb 22, 2021
docs/rules/prefer-array-flat.md
Outdated
| @@ -0,0 +1,53 @@ | |||
| # Prefer `Array#flat()` over legacy techniques to flatten arrays | |||
|
|
|||
| ES2019 introduced a new method [`Array#flat()`](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/flat) that flattens arrays, and there's a [`depth` parameter](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/flat#parameters), so you can flatten deep nesting arrays with it. | |||
There was a problem hiding this comment.
I don't think the depth parameter is relevant. People can read about it when they click the MDN link.
index.js
Outdated
| @@ -84,6 +84,9 @@ module.exports = { | |||
| 'unicorn/prefer-add-event-listener': 'error', | |||
| 'unicorn/prefer-array-find': 'error', | |||
| // TODO: Enable this by default when targeting Node.js 12. | |||
| // TODO[@fisker]: Set to `off` before merge | |||
|
Added a |
|
CI failure should not related, I'll look into it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #975