no-array-push-push
and prefer-ternary
: Improve same reference detection
#1123
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copied a util function
isSameReference
from ESLint core.no-array-push-push
:This was invalid, now it's not considered the same array.
Was not considered same array (we used source code to compare), now they can be recognized.
prefer-ternary
:Only check
Identifier
before, sameMemberExpression
is recognized.->